Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(be:FSADT1-660): adding province list api #323

Merged
merged 9 commits into from
Feb 10, 2023
Merged

Conversation

paulushcgcj
Copy link
Collaborator

@paulushcgcj paulushcgcj commented Feb 9, 2023

Implemented the province list API on the backend.

Fixes # (issue)

Fixes FSADT1-660

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Implemented an integration test to validate pagination and data returned.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

changed some classes to reduce duplication


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added backend code related to the java backend application java Pull requests that update Java code source source code changes tests test classes changes feature labels Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:28 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:28 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:28 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:28 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:30 — with GitHub Actions Inactive
@github-actions github-actions bot added configuration changes related to configuration file feature and removed feature labels Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:46 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:47 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:47 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:47 — with GitHub Actions Inactive
@paulushcgcj paulushcgcj temporarily deployed to dev February 9, 2023 23:47 — with GitHub Actions Inactive
@github-actions github-actions bot added feature and removed feature labels Feb 10, 2023
@github-actions
Copy link

Current changelog

Bug Fixes

  • fe: (#269) (a3417bd)
  • fix frontend test; remove backend comment; added token to pr open pipeline (3b4c7d3)
  • fixing deploy to main (#233) (34b530c)

Features

Reverts

@github-actions github-actions bot mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend code related to the java backend application configuration changes related to configuration file feature java Pull requests that update Java code source source code changes tests test classes changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants